fs: add dot option to glob#63205
Open
owlstronaut wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
nodejs-github-bot
added
fs
Adds an opt-in `dot` boolean option to fs.glob, fs.globSync, and fsPromises.glob. When true, `*` and `**` patterns match basenames that begin with `.`, and the walker descends into directories whose names begin with `.`. Defaults to false to preserve current behavior. Signed-off-by: Michael Smith <owlstronaut@github.com>
owlstronaut
force-pushed
the
owlstronaut/fs-glob-dot-option
branch
from
c2482d4 to
965b503
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63205 +/- ##
==========================================
- Coverage 90.06% 90.05% -0.01%
==========================================
Files 713 713
Lines 224942 224948 +6
Branches 42534 42539 +5
==========================================
- Hits 202590 202588 -2
+ Misses 14147 14142 -5
- Partials 8205 8218 +13
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in
dotboolean option tofs.glob(),fs.globSync(), andfsPromises.glob(). Whentrue,*and**patterns match basenames starting with., and the walker descends into directories whose names startwith
.. Defaults tofalseto preserve current behavior.Followed up from #56321 (comment)